Omer Frenkel has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/25409/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGraphicsDeviceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGraphicsDeviceCommand.java: Line 26: if (dev == null) { Line 27: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DEVICE_MUST_BE_SPECIFIED); Line 28: } Line 29: Line 30: if (getParameters().isVm() && getVmId() == null) { > When adding a new vm, the VM doesn't exist in the db at this moment. addVmCommand calls this command only after the db transaction ends, so the vm should be in the db already, if not you can leave it as is Line 31: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND); Line 32: } Line 33: Line 34: if (!getParameters().isVm() && getVmTemplateId() == null) { http://gerrit.ovirt.org/#/c/25409/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java: Line 23: } Line 24: Line 25: public static GraphicsDevice fromVmDevice(VmDevice vmDev) { Line 26: GraphicsDevice dev = new GraphicsDevice(GraphicsType.fromString(vmDev.getDevice()).getCorrespondingDeviceType()); Line 27: dev.setId(vmDev.getId()); > Actually, graphics device does not have address element. The only thing tha ok Line 28: return dev; Line 29: } Line 30: Line 31: } -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
