Michael Pasternak has posted comments on this change. Change subject: restapi: Add User With Rules Inline ......................................................................
Patch Set 1: Do not submit (3 inline comments) this is turns out to be complicated / awkward functionality, i do not want supporting 1:N role attachment during user creation as this is non-restful and non-atomic operation .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java Line 47: Response response = performCreation(VdcActionType.AddUser, newUser, new UserIdResolver(adUser.getUserId())); what about checking /create/ status? Line 50: Response response2 = getUserSubResource(adUser.getUserId().toString()).getRolesResource().add(role); this is turns out to be complicated + awkward functionality, i do not want supporting 1:N role attachment during user creation .................................................... Commit Message Line 7: restapi: Add User With Rules Inline role, not rules. -- To view, visit http://gerrit.ovirt.org/6516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e4dfb19e95770ec0dd900709ee9728faa7805c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
