Martin Mucha has uploaded a new change for review. Change subject: core: error fix: removed statement negation ......................................................................
core: error fix: removed statement negation statement labelAdded() was mistakenly negated. Change-Id: I4cc3ecc3d45768c0e6896b409bcecb1997d1eff8 Bug-Url: https://bugzilla.redhat.com/1142203 Signed-off-by: Martin Mucha <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/33847/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java index 8750c24..7a1108a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java @@ -136,9 +136,8 @@ private boolean allowedNetworkLabelManipulation() { boolean labelNotChanged = !labelChanged(); - boolean newLabelAssigned = !labelAdded(); - return !getNetwork().isExternal() && (labelNotChanged || newLabelAssigned); + return !getNetwork().isExternal() && (labelNotChanged || labelAdded()); } /** -- To view, visit http://gerrit.ovirt.org/33847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4cc3ecc3d45768c0e6896b409bcecb1997d1eff8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Mucha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
