Alon Bar-Lev has posted comments on this change. Change subject: packaging: fail the build if osinfo-defaults.properties fails to parse ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/33323/7/Makefile File Makefile: Line 233: $(MAKE) maven Line 234: Line 235: post-build-validations: Line 236: if [ "$(BUILD_VALIDATION)" != 0 ]; then \ Line 237: ( cd build/validations && $(MVN) clean test -Dosinfo.properties=../../packaging/conf/osinfo-defaults.properties ); \ > If mvn works like make, doesn't mvn clean test perform clean before perform this is on different directory.... just for validations. but you are right... we should move the clean to make clean. I will push this change. Line 238: fi Line 239: Line 240: clean: Line 241: # Clean maven generated stuff: -- To view, visit http://gerrit.ovirt.org/33323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9aead46c067134dbc59b83ad70d1715ec004587c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
