Martin Peřina has posted comments on this change. Change subject: tools: Replace log4j with slf4j as frontend in engine-config ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33756/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java: Line 106: Class<?> cls = Class.forName("org.ovirt.engine.core.config.entity.helper." + type + "ValueHelper"); Line 107: valueHelper = (ValueHelper) cls.newInstance(); Line 108: } catch (Exception e) { Line 109: // failed finding a helper for this type. Setting default string type Line 110: LoggerFactory.getLogger(EngineConfig.class).debug("Unable to find " + type + " type. Using default string type."); > use {}? Done Line 111: valueHelper = new StringValueHelper(); Line 112: } Line 113: return valueHelper; Line 114: } -- To view, visit http://gerrit.ovirt.org/33756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc3d2a507f51c11b468c6af33a8f714545d3d695 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
