Alon Bar-Lev has posted comments on this change. Change subject: restapi,userportal,webadmin: secure cookie ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33981/2/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 596: sed -i -e \ Line 597: 's#<transport-guarantee>NONE</transport-guarantee>#<transport-guarantee>CONFIDENTIAL</transport-guarantee>#' \ Line 598: -e \ Line 599: 's#<secure>false</secure>#<secure>true</secure>#' \ Line 600: "${war}/WEB-INF/web.xml" hi! sorry for minor comments... but please tabs and -e at same line. sed -i \ -e 's#<transport-guarantee>NONE</transport-guarantee>#<transport-guarantee>CONFIDENTIAL </transport-guarantee>#' \ -e 's#<secure>false</secure>#<secure>true</secure>#' \ "${war}/WEB-INF/web.xml" Line 601: done Line 602: Line 603: # Line 604: # Move jars to destribution location -- To view, visit http://gerrit.ovirt.org/33981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4de909c25ec7b28d12dc7e325c366962c85d32a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
