Alon Bar-Lev has posted comments on this change. Change subject: core: Store only single certificate ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/33717/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ImportProviderCertificateChainCommand.java: Line 66: Line 67: try { Line 68: Certificate certificate = chain.get(chain.size() - 1); Line 69: String alias = Integer.toString(certificate.getEncoded().hashCode()); Line 70: ks.setCertificateEntry(alias, certificate); please move all keystore handling into the ExternalTrustStoreInitializer, pass only certificate. I guess this should use the new chain class? also please remember that we need to fetch the chain single time. Line 71: ExternalTrustStoreInitializer.setTrustStore(ks); Line 72: setSucceeded(true); Line 73: } catch (Throwable e) { Line 74: handleException(e); -- To view, visit http://gerrit.ovirt.org/33717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9bd8cd7f913cf23eca839452b6e113f749966f7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
