Livnat Peer has posted comments on this change.
Change subject: core: Wrong bootproto for non-bridged networks(#842986)
......................................................................
Patch Set 3: Looks good to me, approved
(2 inline comments)
2 minor comments in context.
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 409: VDS_SET_NONOPERATIONAL_IFACE_DOWN=Host ${VdsName} moved to
Non-Operational state because interfaces '${Interfaces}' are down which needed
by networks '${Networks}' in the current cluster
instead of is over I would use is attached to multiple...
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
Line 892:
I would add a comment on this method -
//A bridge which is connected to more than one interface is considered bad
configuration and a warning is issued to the user
and I would also change it !=1 as a bridge that is reported and not connected
to any interface is also a potential problem
--
To view, visit http://gerrit.ovirt.org/6771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie60ac43e27d90c8de2b434a506651360fedd6d9c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
