Allon Mureinik has posted comments on this change. Change subject: core: CI - ban artifacts in common project to avoid compilation problem of GWT ......................................................................
Patch Set 2: Verified; Looks good to me, but someone else must approve Like the concept, like the implementation. Verifications I did: 1. fetched the patch, compiled with it 2. Added commons dependency, checked it failed. 3. ran the build, checked there was no noticeable overhead 4. Imported the project to Eclipse Juno, made sure it works. Question: AFAIK, compat is also used in the GWT modules, so you should also add that there. -- To view, visit http://gerrit.ovirt.org/6785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55c1c380d76f779203017cb17a240fa854fc6308 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
