Hello Tim Speetjens,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34136
to review the following change.
Change subject: aaa: Suppress compiler warnings for unchecked cast
......................................................................
aaa: Suppress compiler warnings for unchecked cast
Suppress two compiler warnings for unchecked casts
There is no more targeted approach for suppressing it properly in
NegotiationFilter, hence the "unchecked" warnings are suppressed
for the complete doFilter method.
Topic: AAA
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1120720
Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c
Signed-off-by: Tim Speetjens <[email protected]>
---
M
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java
M
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/34136/1
diff --git
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java
index 3ed02ae..002103e 100644
---
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java
+++
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java
@@ -38,6 +38,7 @@
if (FiltersHelper.isAuthenticated(req)) {
chain.doFilter(request, response);
} else {
+ @SuppressWarnings("unchecked")
List<String> schemes = (List<String>)
req.getAttribute(FiltersHelper.Constants.REQUEST_SCHEMES_KEY);
if (schemes == null) {
schemes = Collections.emptyList();
diff --git
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
index a9f751e..59e02a0 100644
---
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
+++
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java
@@ -102,6 +102,7 @@
);
}
+ @SuppressWarnings("unchecked")
@Override
public void doFilter(ServletRequest req, ServletResponse rsp, FilterChain
chain)
throws IOException, ServletException {
--
To view, visit http://gerrit.ovirt.org/34136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I730d91cdb7392f91e475642230a5c499f235f73c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Tim Speetjens <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
