Ayal Baron has posted comments on this change.
Change subject: improvment - use stored procedure instead of search language
......................................................................
Patch Set 6: (5 inline comments)
This patch should be squashed with its parent
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
Line 90:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_VDS_IN_POOL);
just return false
Line 91: } else {
no need for 'else'
Line 95: return returnValue;
return true
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolStatusHandler.java
Line 90: if
(DbFacade.getInstance().getVdsDAO().getAllVdsByPoolIdAndStatus(pool.getId(),
VDSStatus.Up).size() > 0) {
s/DbFac...getVdsDAO/getVdsDAO/
....................................................
Commit Message
Line 9: retrive UP Hosts in DC using a proper SP instead of heavy and unreadable
s/retrive/retrieve/
--
To view, visit http://gerrit.ovirt.org/6145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3704dd900b3ed2c23a4dae307eb4f23a4d73df2f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
