Martin Peřina has uploaded a new change for review.

Change subject: webadmin: Fix vertical positioning of checkbox and label
......................................................................

webadmin: Fix vertical positioning of checkbox and label

Fixes vertical positioning of checkbox and its label if checkbox is
placed on the right of its label.

Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75
Related-To: https://bugzilla.redhat.com/1148868
Signed-off-by: Martin Perina <[email protected]>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
M packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/34145/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
index a44b905..7a4a87f 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseEntityModelCheckboxEditor.java
@@ -56,6 +56,9 @@
         // patternfly hacks
         getContentWidgetElement().addClassName("cbe_checkbox_pfly_fix"); 
//$NON-NLS-1$
         getInternalLabelElement().addClassName("cbe_label_pfly_fix"); 
//$NON-NLS-1$
+        if (!useCheckBoxWidgetLabel) {
+            addWrapperStyleName("cbe_right_of_label_pfly_fix"); //$NON-NLS-1$
+        }
 
     }
 
diff --git a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css 
b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
index d5b88ad..6991f69 100644
--- a/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
+++ b/packaging/branding/ovirt.brand/ovirt-patternfly-compat.css
@@ -120,6 +120,14 @@
     position: relative;
     top: 2px;
 }
+
+.cbe_right_of_label_pfly_fix {
+}
+
+.cbe_right_of_label_pfly_fix .cbe_checkbox_pfly_fix {
+    top: -2px;
+}
+
 .cbe_label_pfly_fix {
     padding-left: 5px;
 }


-- 
To view, visit http://gerrit.ovirt.org/34145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38f8cf40fccfb0ec34672915f7aad15b2b08da75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Martin Peřina <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to