Alona Kaplan has posted comments on this change. Change subject: engine: Add getManagementNetworks to NetworkDao ......................................................................
Patch Set 5: (4 comments) http://gerrit.ovirt.org/#/c/33252/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java: Line 147: */ Line 148: Network getManagementNetwork(Guid clusterId); Line 149: Line 150: /** Line 151: * Retrieves the management network for the given DC. s/network/networks Line 152: * Line 153: * @param dataCenterId Line 154: * the data center the network is belongs to Line 155: * Line 152: * Line 153: * @param dataCenterId Line 154: * the data center the network is belongs to Line 155: * Line 156: * @return the management {@link Network} Please fix the return statement Line 157: */ Line 158: List<Network> getManagementNetworks(Guid dataCenterId); http://gerrit.ovirt.org/#/c/33252/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java: Line 99: assertEquals(MANAGEMENT_NETWORK_ID, result.getId()); Line 100: } Line 101: Line 102: /** Line 103: * Ensures that all management networks networks are returned. typo- networks networks Line 104: */ Line 105: @Test Line 106: public void testGetManagementNetworks() { Line 107: List<Network> result = dao.getManagementNetworks(datacenter); http://gerrit.ovirt.org/#/c/33252/5/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1035: Create or replace FUNCTION GetAllManagementNetworksByDataCenterId(v_data_center_id UUID) Line 1036: RETURNS SETOF network STABLE Line 1037: AS $procedure$ Line 1038: BEGIN Line 1039: RETURN QUERY Please remove the redundant whitespace. Line 1040: SELECT network.* Line 1041: FROM network Line 1042: JOIN network_cluster ON network.id = network_cluster.network_id Line 1043: JOIN vds_groups ON network_cluster.cluster_id = vds_groups.vds_group_id -- To view, visit http://gerrit.ovirt.org/33252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I967abeb41bfc086962cdcc3c3878e16cbaa4636b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
