Alon Bar-Lev has posted comments on this change. Change subject: core: Replace log4j with slf4j in docs ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/34178/1/backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java File backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java: Line 70: properties = p.entrySet(); Line 71: } Line 72: catch (IOException e) { Line 73: log.error("Problem parsing Properties file '{}'", configFile.getAbsolutePath()); //$NON-NLS-1$ Line 74: log.error("Exception", e); //$NON-NLS-1$ debug Line 75: } Line 76: } Line 77: Line 78: // for every HELPTAGS_PREFIX line in the properties file, read all json files, merge them, and put them in cachedJson Line 94: nodes.add(mapper.readTree(reader)); Line 95: } Line 96: catch (IOException e) { Line 97: log.error("Problem parsing documentation mapping file '{}'", file.getAbsolutePath()); //$NON-NLS-1$ Line 98: log.error("Exception", e); //$NON-NLS-1$ debug Line 99: } Line 100: } Line 101: } Line 102: http://gerrit.ovirt.org/#/c/34178/1/backend/manager/modules/docs/src/main/resources/META-INF/MANIFEST.MF File backend/manager/modules/docs/src/main/resources/META-INF/MANIFEST.MF: you can remove file Line 1: Manifest-Version: 1.0 -- To view, visit http://gerrit.ovirt.org/34178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b7ebf1740eb46aa6e03925ca3530ecf1296f5fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
