Martin Peřina has posted comments on this change.

Change subject: core: Replace log4j with slf4j in services
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/34180/1/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
File 
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java:

Line 74:                 out.print(resource.toString(format, alias));
Line 75:             }
Line 76:         }
Line 77:         catch(Exception e) {
Line 78:             log.error("Cannot send public key resource '{}' format 
'{}'", resourceStr, formatStr);
> add : {} with e.getMessage()
Done
Line 79:             log.error("Exception", e);
Line 80:             response.sendError(HttpServletResponse.SC_BAD_REQUEST, 
e.getMessage());
Line 81:         }
Line 82:     }


Line 75:             }
Line 76:         }
Line 77:         catch(Exception e) {
Line 78:             log.error("Cannot send public key resource '{}' format 
'{}'", resourceStr, formatStr);
Line 79:             log.error("Exception", e);
> debug
Done
Line 80:             response.sendError(HttpServletResponse.SC_BAD_REQUEST, 
e.getMessage());
Line 81:         }
Line 82:     }


-- 
To view, visit http://gerrit.ovirt.org/34180
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I380f76268b4e69868668fcac987c703fbeaed386
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to