Martin Peřina has posted comments on this change. Change subject: frontend: Replace log4j with slf4j ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/34182/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java: Line 241 Line 242 Line 243 Line 244 Line 245 > no need ^ Done Line 252 Line 253 Line 254 Line 255 Line 256 > no need ^ Done http://gerrit.ovirt.org/#/c/34182/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginDataManager.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginDataManager.java: Line 251: JsonNode node = null; Line 252: try { Line 253: node = mapper.readValue(file, JsonNode.class); Line 254: } catch (IOException e) { Line 255: log.warn("Cannot read/parse JSON file '{}'", file.getAbsolutePath()); //$NON-NLS-1$ > add : {} and e.getMessage() Done Line 256: log.warn("Exception", e); // $NON-NLS-1$ Line 257: } Line 258: return node; Line 259: } Line 252: try { Line 253: node = mapper.readValue(file, JsonNode.class); Line 254: } catch (IOException e) { Line 255: log.warn("Cannot read/parse JSON file '{}'", file.getAbsolutePath()); //$NON-NLS-1$ Line 256: log.warn("Exception", e); // $NON-NLS-1$ > debug Done Line 257: } Line 258: return node; Line 259: } Line 260: -- To view, visit http://gerrit.ovirt.org/34182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea13c66ca38380e0e6017921d135051e0342f565 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
