Alon Bar-Lev has posted comments on this change.
Change subject: core: drop commons-logging
......................................................................
Patch Set 2:
> I assume you used git grep {0} or something like that to go over all places
> that potentially need format change?
the format of the ovirt log is still using {0}, next patch should be to convert
it to the org.slf4j.Logger interface and convert the entire project to use {}
and drop the xxxFormat.
and then remove this class in favor of custom formatter that inject the
correlation without using the ovirt logger at all.
--
To view, visit http://gerrit.ovirt.org/34214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8903f7b605017f2c5bf08768d6462afdbaf14833
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
