Sahina Bose has posted comments on this change. Change subject: engine : Vds Command for geo-rep session pause ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/32666/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java: Line 404: GlusterGeoRepSessionDeleteFailedException(4594), Line 405: GlusterVolumeGeoRepStopFailedException(4596), Line 406: GlusterVolumeGeoRepStatusFailed(4599), Line 407: GlusterVolumeGeoRepStatusDetailFailed(4600), Line 408: GlusterVolumeGeoRepPauseFailed(4574), > Done As per http://gerrit.ovirt.org/#/c/31069/2/vdsm/gluster/exception.py, the code for this is 4597 Line 409: Line 410: UnicodeArgumentException(4900), Line 411: Line 412: // oVirt errors http://gerrit.ovirt.org/#/c/32666/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java: Line 139: AddGlusterServer("org.ovirt.engine.core.vdsbroker.gluster"), Line 140: GlusterServersList("org.ovirt.engine.core.vdsbroker.gluster"), Line 141: StartGlusterVolumeProfile("org.ovirt.engine.core.vdsbroker.gluster"), Line 142: StopGlusterVolumeProfile("org.ovirt.engine.core.vdsbroker.gluster"), Line 143: GlusterVolumeGeoRepPause("org.ovirt.engine.core.vdsbroker.gluster"), change to PauseGlusterVolumeGeoRepSession? Line 144: GetGlusterVolumeAdvancedDetails("org.ovirt.engine.core.vdsbroker.gluster"), Line 145: GlusterVolumesList("org.ovirt.engine.core.vdsbroker.gluster"), Line 146: GetGlusterVolumeProfileInfo("org.ovirt.engine.core.vdsbroker.gluster"), Line 147: EnableGlusterHook("org.ovirt.engine.core.vdsbroker.gluster"), http://gerrit.ovirt.org/#/c/32666/4/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 738: Line 739: @DefaultStringValue("Gluster Volume Profile Stop Failed.") Line 740: String GlusterVolumeProfileStopFailed(); Line 741: Line 742: @DefaultStringValue("Gluster Volume geo-replication pause failed") Change error message to be more user friendly? Line 743: String GlusterVolumeGeoRepPauseFailed(); Line 744: Line 745: String ACTIVATE_NIC_FAILED(); Line 746: -- To view, visit http://gerrit.ovirt.org/32666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e34c69b43355b9d8b8305467508047f65aeb05a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
