Roy Golan has posted comments on this change. Change subject: core: prevent maintenance a host with hard affinity ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34060/2/packaging/dbscripts/affinity_groups_sp.sql File packaging/dbscripts/affinity_groups_sp.sql: Line 134: LANGUAGE plpgsql; Line 135: Line 136: -- Get All positive enforcing Affinity Groups which contain VMs running on given host id Line 137: Create or replace FUNCTION getPositiveEnforcingAffinityGroupsByRunningVmsOnVdsId(v_vds_id UUID) RETURNS SETOF affinity_groups_view STABLE Line 138: AS $procedure$ the syntax I see mostly is Create or replace..... RETURNS QUERY as $procedure$ BEGIN SELECT.... where your first line after the BEGIN is RETURN. just keep this conventional I guess Line 139: BEGIN Line 140: RETURN QUERY Line 141: SELECT DISTINCT affinity_groups_view.* FROM affinity_groups_view Line 142: INNER JOIN affinity_group_members ON id = affinity_group_members.affinity_group_id -- To view, visit http://gerrit.ovirt.org/34060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
