Lior Vernia has posted comments on this change. Change subject: engine: Code needs to run once, remove from loop ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34130/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java: Line 41: Line 42: private Map<String, Object> generateNetworks() { Line 43: Map<String, Object> networks = new HashMap<String, Object>(); Line 44: NetworkQoSDao qosDao = getDbFacade().getNetworkQosDao(); Line 45: VDS host = getDbFacade().getVdsDao().get(getParameters().getVdsId()); > even this call is redundant as we already have the vds entity out of the sc Just to clarify, as I don't see that the VDS member is explicitly set in this command - you're suggesting to pass the VDS as part of the parameters from SetupNetworksCommand? Line 46: Line 47: boolean hostNetworkQosSupported = FeatureSupported.hostNetworkQos(host.getVdsGroupCompatibilityVersion()); Line 48: Line 49: Set<Version> supportedClusterVersionsSet = host.getSupportedClusterVersionsSet(); -- To view, visit http://gerrit.ovirt.org/34130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
