Alon Bar-Lev has posted comments on this change.

Change subject: core: Added the table vds_deploy_config
......................................................................


Patch Set 10:

I renamed the tables and other stuff, but cannot get the dao tests working... 
so need help.

Next:

I would like the type to be java type, pure java... so we can construct:

java.lang.Boolean
java.lang.Integer
java.lang.String
java.lang.String[]
null

The Boolean, Integer, String can be constructed by feeding the value into 
reflection valueOf.

The null - just get it as is and set null.

The string [] - although not mandatory, it will be nice to support that... 
using a format within the value? something else?

-- 
To view, visit http://gerrit.ovirt.org/27028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc58b36dccfd23165dd5b0dfb7c2c86cf261f488
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to