Oved Ourfali has posted comments on this change. Change subject: core: protocol fall back for older vdsms ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34255/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java: Line 166: if (checkProtocolTofallback(getVds())) { Line 167: // we need to check whether we are connecting to vdsm which supports xmlrpc only Line 168: ProtocolDetector detector = new ProtocolDetector(getVds()); Line 169: if (!detector.attemptConnection()) { Line 170: detector.stopConnection(); as long as stopConnection is calling RemoveVds, the else clause here is erronous (InstallFailed). Line 171: if (detector.attemptFallbackProtocol()) { Line 172: detector.setFallbackProtocol(); Line 173: } else { Line 174: throw new VdsInstallException(VDSStatus.InstallFailed, "Host not reachable"); http://gerrit.ovirt.org/#/c/34255/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java: Line 42: */ Line 43: public boolean attemptConnection() { Line 44: boolean connected = false; Line 45: try { Line 46: for (int i = 0; i < 3; i++) { please make this a constant as well (3). Line 47: long timeout = Config.<Integer> getValue(ConfigValues.SetupNetworksPollingTimeout); Line 48: FutureVDSCall<VDSReturnValue> task = Line 49: Backend.getInstance().getResourceManager().runFutureVdsCommand(FutureVDSCommandType.TimeBoundPoll, Line 50: new TimeBoundPollVDSCommandParameters(vds.getId(), timeout, TimeUnit.SECONDS)); -- To view, visit http://gerrit.ovirt.org/34255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9af3129a4adf839f2d4c2e110425a6c69e45256 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
