Alona Kaplan has posted comments on this change. Change subject: engine: update AddVdsGroupCommand ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/33416/8/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java: Line 154: @Test Line 155: public void managementNetworkChangeValidNoChangeAfterAttachment4() { Line 156: testManagementNetworkChangeAfterAttachement(null, Boolean.TRUE, true, currentManagementNetwork, isValid()); Line 157: } Line 158: > Please add the following test cases- Please ignore points 2 and 3- in case of AttachNetowrkToCluster it is assumed that the currentManagementNetwork is not the one being attached, so the test are redundant. Make sure these test cases are done for update. Line 159: @Test Line 160: public void managementNetworkChangeInnalidAfterAttachment() { Line 161: testManagementNetworkChangeAfterAttachement( Line 162: null, -- To view, visit http://gerrit.ovirt.org/33416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I196a583ae7d8d7e373a1aca2a48e592232b18a5b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
