Yair Zaslavsky has uploaded a new change for review. Change subject: aaa: Change DbUser getters of group fields ......................................................................
aaa: Change DbUser getters of group fields The getters will return a copy of the collection and not an umodifyable collection, as unmofiyable collection as no default ctor, thus cannot be deserialized by jackson Topic: AAA Bug-Url: https://bugzilla.redhat.com/1155084 Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/34386/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java index 550656f..d2de0f8 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/DbUser.java @@ -1,5 +1,6 @@ package org.ovirt.engine.core.common.businessentities.aaa; +import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.HashSet; @@ -176,7 +177,7 @@ } public Collection<String> getGroupNames() { - return Collections.unmodifiableCollection(groupNames); + return new ArrayList<String>(groupNames); } public void setGroupNames(Collection<String> value) { @@ -232,7 +233,7 @@ if (groupIds == null) { groupIds = Collections.emptyList(); } - return Collections.unmodifiableCollection(groupIds); + return new ArrayList<Guid>(groupIds); } @Override -- To view, visit http://gerrit.ovirt.org/34386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03873642ac547b11c66bad42b68c33d7687c8d5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
