Michael Pasternak has posted comments on this change. Change subject: cli: Check returned object identity ......................................................................
Patch Set 4: -Code-Review Juan, the reason for the issue you've addressed here is wrong behaviour of engine api, when filter=true, api should not return any object at all, as ?search is not supported in the user mode, as about cli, when filter=true, it should not use ?search to locate the resource by name, but listing of resources via list() + kwargs filtering on client side (IIRC max=-1 will unlimit it) so no obj will be returned if no kwargs match has found (unfortunately this code was written way before user-api, thus it not addresses issue arise in this mode), your fix will definitely work for now, but once rest-api is fixed, - it will break, so moving to propose above is a way forward in my view. (p.s fixing rest-api is important as it users may face same issue) -- To view, visit http://gerrit.ovirt.org/34373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3cd770f6e84f814a54b8510954797230d4cf797 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
