Piotr Kliczewski has posted comments on this change.

Change subject: core: configurable ssl protocol
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/34372/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java:

Line 389:     @DefaultValueAttribute("true")
Line 390:     EncryptHostCommunication,
Line 391:     @TypeConverterAttribute(String.class)
Line 392:     @DefaultValueAttribute("TLSv1")
Line 393:     SSLProtocol,
> VdsmSLLProtocol?
Done
Line 394:     @Reloadable
Line 395:     @TypeConverterAttribute(String.class)
Line 396:     @DefaultValueAttribute("oVirt")
Line 397:     OrganizationName,


http://gerrit.ovirt.org/#/c/34372/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

Line 632: select 
fn_db_add_config_value('DelayResetForSpmInSeconds','20','general');
Line 633: select 
fn_db_add_config_value('DelayResetPerVmInSeconds','0.5','general');
Line 634: --Handling Use Secure Connection with Hosts
Line 635: select 
fn_db_add_config_value('EncryptHostCommunication','true','general');
Line 636: select fn_db_add_config_value('SSLProtocol','TLSv1','general');
> if this will effect legacy protocol we should probably have two?
I am not sure what do you suggest here
Line 637: select 
fn_db_add_config_value('TimeToReduceFailedRunOnVdsInMinutes','30','general');
Line 638: select 
fn_db_add_config_value('UnknownTaskPrePollingLapse','60000','general');
Line 639: select fn_db_add_config_value('UserSessionHardLimit','600','general');
Line 640: select fn_db_add_config_value('UserDefinedVMProperties','','3.0');


-- 
To view, visit http://gerrit.ovirt.org/34372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33a33c15e8a995eb8de7d5131b3dbadc6191f873
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to