Vitor de Lima has posted comments on this change. Change subject: core, engine, webadmin: Consider only online logical CPUs ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/33788/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 29: private Integer cpuThreads; Line 30: Line 31: private String cpu_model; Line 32: Line 33: private String online_cpus; > please use java naming conventions (onlineCpus) Done Line 34: Line 35: private BigDecimal cpu_speed_mh; Line 36: Line 37: private String if_total_speed; http://gerrit.ovirt.org/#/c/33788/3/packaging/dbscripts/upgrade/03_06_0410_add_online_cpu_list.sql File packaging/dbscripts/upgrade/03_06_0410_add_online_cpu_list.sql: Line 1: select fn_db_add_column('vds_dynamic', 'online_cpus', 'VARCHAR(1000)'); > why 1000 ??? Done http://gerrit.ovirt.org/#/c/33788/3/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 292: v_is_numa_supported BOOLEAN, Line 293: v_supported_rng_sources VARCHAR(255), Line 294: v_is_live_snapshot_supported BOOLEAN, Line 295: v_is_live_merge_supported BOOLEAN, Line 296: v_online_cpus VARCHAR(1000)) > varchar(1000) => text Done Line 297: RETURNS VOID Line 298: Line 299: --The [vds_dynamic] table doesn't have a timestamp column. Optimistic concurrency logic cannot be generated Line 300: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/33788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib20f20d6003502fe2f2864abb5ad8f4f5a19ecdc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
