Einav Cohen has posted comments on this change.

Change subject: webadmin: Make call to backend "more" async (#840388)
......................................................................


Patch Set 1: (1 inline comment)

see my inline comment.

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
Line 538:         if (returnValue != null) {
in order to keep the behavior similar to the old one as much as possible, we 
need to check here that the "succeeded" value of "all" return values is "true", 
so the dialog will stay opened in case something went wrong during the 
CanDoAction phase, and will be closed only if the CanDoAction phase succeeded.

--
To view, visit http://gerrit.ovirt.org/6899
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12a0b708e61d21b2a6276620d7350e626eb12fd8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to