Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 23: (3 comments) http://gerrit.ovirt.org/#/c/33458/23/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 63: try { Line 64: result = CertificateChain.getSSLPeerCertificates(url); Line 65: Line 66: } catch (CertificateException | NoSuchAlgorithmException | InvalidKeyException | NoSuchProviderException Line 67: | SignatureException | SSLHandshakeException ex) { most probably these are GeneralSecurityException, why do you ignore these? at least log the error? Line 68: } catch (IOException | GeneralSecurityException e) { Line 69: handleException(e); Line 70: } Line 71: } http://gerrit.ovirt.org/#/c/33458/23/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java: Line 142: public File getCacheDir() { Line 143: return getFile("ENGINE_CACHE"); Line 144: } Line 145: Line 146: public File getTrustStore() { getExternalProvidersTrustStore? Line 147: return getFile("ENGINE_TRUST_STORE"); Line 148: } Line 149: Line 150: /** http://gerrit.ovirt.org/#/c/33458/23/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 28: ENGINE_USR="@ENGINE_USR@" Line 29: ENGINE_DOC="@ENGINE_DOC@" Line 30: ENGINE_VAR="@ENGINE_VAR@" Line 31: ENGINE_CACHE="@ENGINE_CACHE@" Line 32: ENGINE_TRUST_STORE="${ENGINE_USR}/external_truststore" please move this to where all pki stuff is. please keep the place, it should be ENGINE_VAR please name this for external providers, as it is not the entire engine trust store, we already have one. ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE? Line 33: ENGINE_MANUAL="${ENGINE_USR}/manual" Line 34: Line 35: # Line 36: # A file created on init and removed on orderly shutdown -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
