Moti Asayag has posted comments on this change. Change subject: core: Do Not Allow Same Mac Address (#xxxxxx Waiting for BZ) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java Line 201: since there is more to go after the MAC Address allocation, please modify the call for "return super.canDoAction();" to "return true" to make sure that any future implementation of canDoAction by any parent of AddVmInterfaceCommand won't cause failure and leaving the allocated mac address in pool (rather freeing it). -- To view, visit http://gerrit.ovirt.org/6911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cfcf0c15bc494f1debd4bdd3e15bd396b179323 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
