Yair Zaslavsky has posted comments on this change. Change subject: fix handling of admin user while login ......................................................................
Patch Set 1: Verified-1 (1 comment) Please notice the dao failure, looks like real issue. http://gerrit.ovirt.org/#/c/34551/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java: Line 54: */ Line 55: public static boolean isAdminUser(DbUser user) { Line 56: List<Role> userRoles = Line 57: getRoleDAO().getAnyAdminRoleForUserAndGroups(user.getId(), StringUtils.join(user.getGroupIds(), ",")); Line 58: if (userRoles.size() > 0) { i think !userRoles.isEmpty() is nicer. Line 59: log.debug("LoginAdminUser: User logged to admin using role '{}'", userRoles.get(0).getname()); Line 60: return true; Line 61: } Line 62: return false; -- To view, visit http://gerrit.ovirt.org/34551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aa489199c904008e46a650f11877091931ee5de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
