Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: Add ManagementNetworkUtil ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/32992/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtil.java: Line 24: */ Line 25: boolean isManagementNetwork(Guid networkId); Line 26: Line 27: /** Line 28: * The method checks if the given network is defined as the management network for the given cluster cluster. > You didn't fix the typo- cluster cluster Done Line 29: * Line 30: * @param networkId Line 31: * the given network id Line 32: * @param clusterId http://gerrit.ovirt.org/#/c/32992/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/ManagementNetworkUtilImplTest.java: Line 112: testIsManagementNetworkInGivenClusterCommon(false); Line 113: } Line 114: Line 115: private void testIsManagementNetworkInGivenClusterCommon(boolean expectedResult) { Line 116: when(mockNetworkClusterDao.get(eq(TEST_NETWORK_CLUSTER_ID))).thenReturn(mockNetworkCluster); > You should also verify that the get was called only once. Now, when Captor is not used, verify is not very important here. Asserting the actual result should be enough IMHO. Line 117: when(mockNetworkCluster.isManagement()).thenReturn(expectedResult); Line 118: Line 119: final boolean actual = underTest.isManagementNetwork(TEST_NETWORK_ID, TEST_CLUSTER_ID); Line 120: -- To view, visit http://gerrit.ovirt.org/32992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4117f9e97e721c847f5192e1ab724c8d231ce4f3 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
