Omer Frenkel has posted comments on this change.

Change subject: core: disable the mixing of RHEL6 and RHEL7 in one cluster
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/34653/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java:

Line 935: 
Line 936:     EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER(9604, 
AuditLogSeverity.WARNING,
Line 937:             AuditLogTimeInterval.MINUTE.getValue()),
Line 938: 
Line 939:     EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER_LEVEL(9609, 
AuditLogSeverity.WARNING,
why do you need this one above? looks like a mistake
Line 940:             AuditLogTimeInterval.MINUTE.getValue()),
Line 941: 
Line 942:     MIXING_RHEL_VERSIONS_IN_CLUSTER(9610, AuditLogSeverity.WARNING,
Line 943:             AuditLogTimeInterval.MINUTE.getValue()),


http://gerrit.ovirt.org/#/c/34653/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java:

Line 23:     GLUSTER_HOST_UUID_ALREADY_EXISTS(15),
Line 24:     ARCHITECTURE_INCOMPATIBLE_WITH_CLUSTER(16),
Line 25:     NETWORK_INTERFACE_IS_DOWN(17),
Line 26:     RNG_SOURCES_INCOMPATIBLE_WITH_CLUSTER(18),
Line 27:     EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER_LEVEL(19),
same
Line 28:     MIXING_RHEL_VERSIONS_IN_CLUSTER(20);
Line 29: 
Line 30:     private final int value;
Line 31: 


-- 
To view, visit http://gerrit.ovirt.org/34653
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb6d41b1921a6caf946cba44a6c92ef86fef6bc8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to