Francesco Romani has uploaded a new change for review. Change subject: core: assume live snapshot supported as default ......................................................................
core: assume live snapshot supported as default VDSM will report if underlying QEMU reports live snapshot or not. This information is provided through libvirt. If libvirt, or VDSM, no longer report this capability, Engine get stuck with the old value and it is no longer updated. There is an unlucky case on CentOS and RHEL 6.6 on which we can hit this condition. To fix that, this patch assumes live snapshot is supported if we don't have word from VDSM. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1159211 Related-To: http://bugzilla.redhat.com/1149460 Related-To: http://bugzilla.redhat.com/1158974 Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Signed-off-by: Francesco Romani <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/34742/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java index 862f765..101703f 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java @@ -508,6 +508,8 @@ if (xmlRpcStruct.containsKey(VdsProperties.liveSnapshotSupport)) { vds.setLiveSnapshotSupport(AssignBoolValue(xmlRpcStruct, VdsProperties.liveSnapshotSupport)); + } else { + vds.setLiveSnapshotSupport(true); // for backward compatibility's sake } if (xmlRpcStruct.containsKey(VdsProperties.liveMergeSupport)) { vds.setLiveMergeSupport(AssignBoolValue(xmlRpcStruct, VdsProperties.liveMergeSupport)); -- To view, visit http://gerrit.ovirt.org/34742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4660560e08f606e2b16a580ef60618abfad49244 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
