Alon Bar-Lev has posted comments on this change. Change subject: core: Adjust websockify to the new API ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32138/1/packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py File packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py: Line 72: def get_logger(): Line 73: return OvirtWebSocketProxy._logger Line 74: Line 75: class OvirtProxyRequestHandler(OvirtProxyRequestHandlerBase, Line 76: websockify.ProxyRequestHandler): multiple inheritance is bad idea in python Line 77: pass Line 78: Line 79: else: # remove this branch when python-websockify is >= 0.6 Line 80: class OvirtWebSocketProxy(OvirtProxyRequestHandlerBase, Line 209: pidfile=self.pidfile, Line 210: ) Line 211: Line 212: def daemonStdHandles(self): Line 213: consoleLog = open(os.devnull, 'w+') > > it is up to us what is within rhel... no? so I am thinking about providing two implementations and execute the one based on version, this will avoid workaround and such. Line 214: return (consoleLog, consoleLog) Line 215: Line 216: def daemonContext(self): Line 217: # -- To view, visit http://gerrit.ovirt.org/32138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13f94f91a1bdee0bfa93dc263de7e51395f7d7ce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
