Yevgeny Zaspitsky has posted comments on this change. Change subject: core: Add host network QoS entity ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34119/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java: Line 15: * Base class for QoS objects derived class will hold qos limit according to type. Line 16: */ Line 17: public class QosBase extends IVdcQueryable implements BusinessEntity<Guid>, Serializable { Line 18: Line 19: private static final String UNLIMITED= "Unlimited"; shouldn't a space character come before '=' sign? Line 20: private static final long serialVersionUID = 1122772549710787678L; Line 21: private Guid id = Guid.Empty; Line 22: private QosType qosType; Line 23: -- To view, visit http://gerrit.ovirt.org/34119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9471e68ba36fcc2f1465059037125a4c19a4c07f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
