Alona Kaplan has posted comments on this change. Change subject: engine: Implement HostNetworkQos [de]serialization ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34122/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkQosMapper.java: Line 74: return null; Line 75: } Line 76: Line 77: Double average = parameters.get(VdsProperties.HOST_QOS_AVERAGE); Line 78: return (average == null) ? null : (int) (average / conversionRate); How is it possible to get a non-integer value? Is there a way to set the value via the host? If there is, it would be more accurate to save the qos parameters on HostNetworkQos as doubles. Or even saving it as integer but in bits and just displaying it to the user in Mb. I don't understand the benefit of sending/receiving bits as doubles through the api with vdsm. Line 79: } Line 80: -- To view, visit http://gerrit.ovirt.org/34122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fab9e53938823463ff01af0a153390804f276c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
