Idan Shaby has uploaded a new change for review.

Change subject: frontend: Clear Inactive ISO Domain Images List
......................................................................

frontend: Clear Inactive ISO Domain Images List

When an ISO domain is not active, navigating to its images subtab
should not query for the images, but show an empty list.

Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16
Bug-Url: https://bugzilla.redhat.com/1155191
Signed-off-by: Idan Shaby <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/34790/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
index 046f7ca..0d75d76 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
@@ -7,6 +7,7 @@
 import org.ovirt.engine.core.common.businessentities.ImageFileType;
 import org.ovirt.engine.core.common.businessentities.RepoImage;
 import org.ovirt.engine.core.common.businessentities.StorageDomain;
+import org.ovirt.engine.core.common.businessentities.StorageDomainStatus;
 import org.ovirt.engine.core.common.businessentities.StorageType;
 import org.ovirt.engine.core.common.queries.GetImagesListParameters;
 import org.ovirt.engine.core.common.queries.VdcQueryReturnValue;
@@ -94,6 +95,10 @@
         }
 
         StorageDomain storageDomain = (StorageDomain) getEntity();
+        if (storageDomain.getStatus() != StorageDomainStatus.Active) {
+            setItems(Collections.<StorageDomain>emptyList());
+            return;
+        }
 
         GetImagesListParameters imagesListParams = new 
GetImagesListParameters(storageDomain.getId(), ImageFileType.All);
         imagesListParams.setForceRefresh(true);


-- 
To view, visit http://gerrit.ovirt.org/34790
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb29eb14a07a8084b62bda5ac41769ce964bac16
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to