Lior Vernia has posted comments on this change. Change subject: engine: Create backend commands for HostNetworkQos ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/34124/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddHostNetworkQosCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddHostNetworkQosCommand.java: Line 5: import org.ovirt.engine.core.common.businessentities.network.HostNetworkQos; Line 6: import org.ovirt.engine.core.dao.network.HostNetworkQosDao; Line 7: Line 8: public class AddHostNetworkQosCommand extends AddQosCommand<HostNetworkQos, HostNetworkQosValidator> { Line 9: > What about the canDoAction? requiredValuesPresent() and valuesConsistent()? Done Line 10: public AddHostNetworkQosCommand(QosParametersBase<HostNetworkQos> parameters) { Line 11: super(parameters); Line 12: } Line 13: http://gerrit.ovirt.org/#/c/34124/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateHostNetworkQosCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateHostNetworkQosCommand.java: Line 5: import org.ovirt.engine.core.common.businessentities.network.HostNetworkQos; Line 6: import org.ovirt.engine.core.dao.network.HostNetworkQosDao; Line 7: Line 8: public class UpdateHostNetworkQosCommand extends UpdateQosCommandBase<HostNetworkQos, HostNetworkQosValidator> { Line 9: > What about the canDoAction? requiredValuesPresent() and valuesConsistent()? Done Line 10: public UpdateHostNetworkQosCommand(QosParametersBase<HostNetworkQos> parameters) { Line 11: super(parameters); Line 12: } Line 13: http://gerrit.ovirt.org/#/c/34124/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 332: RemoveStorageQos(1755, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 333: AddCpuQos(1756, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 334: UpdateCpuQos(1757, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 335: RemoveCpuQos(1758, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 336: AddHostNetworkQos(1770, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), > Why not- 1766/7/8? Seemed like 176? are used for profiles. Line 337: UpdateHostNetworkQos(1771, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 338: RemoveHostNetworkQos(1772, ActionGroup.EDIT_STORAGE_POOL_CONFIGURATION, false, QuotaDependency.NONE), Line 339: // disk profiles Line 340: AddDiskProfile(1760, ActionGroup.CREATE_STORAGE_DISK_PROFILE, false, QuotaDependency.NONE), -- To view, visit http://gerrit.ovirt.org/34124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c3b377592e0c4d3584867414e3ad23ec25b6ad3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
