Moti Asayag has posted comments on this change.
Change subject: engine: Replace message of interface not exists (#844158)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
Line 76: if
(!getExistingIfaces().containsKey(NetworkUtils.StripVlan(name))) {
why not extract NetworkUtils.StripVlan(name) into local variable and reuse its
value in case of an error ?
--
To view, visit http://gerrit.ovirt.org/6945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffe581725ead596ba2b43e6ce96b966b6bae5c10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
