Allon Mureinik has posted comments on this change. Change subject: core: Add alias and description for disk meta data ......................................................................
Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34163/6/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java: Line 125: String diskAlias = null; Line 126: try { Line 127: diskAlias = ImagesHandler.getJsonDiskDescription("DiskAlias", "DiskDescription"); Line 128: } catch (IOException e) { Line 129: e.printStackTrace(); Seriously? Define the method as throws Exception, and let the test fail if it throws. Line 130: } Line 131: assertTrue("Should be map of disk alias and disk description", Line 132: diskAlias.equals("{\"DiskDescription\":\"DiskDescription\",\"DiskAlias\":\"DiskAlias\"}")); Line 133: } -- To view, visit http://gerrit.ovirt.org/34163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2642ae7016579ead699509426e01ac2010bd374 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
