Alona Kaplan has posted comments on this change. Change subject: webadmin: Add host network QoS subtab ......................................................................
Patch Set 4: (6 comments) http://gerrit.ovirt.org/#/c/34129/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java: Line 44: Line 45: TextColumnWithTooltip<HostNetworkQos> nameColumn = new TextColumnWithTooltip<HostNetworkQos>() { Line 46: @Override Line 47: public String getValue(HostNetworkQos object) { Line 48: return object.getName() == null ? "" : object.getName(); //$NON-NLS-1$ If you got to here and the name is null, it means something went wrong. Maybe it worth to add assertion in this case. Line 49: } Line 50: }; Line 51: nameColumn.makeSortable(); Line 52: getTable().addColumn(nameColumn, constants.storageQosName(), "200px"); //$NON-NLS-1$ Line 48: return object.getName() == null ? "" : object.getName(); //$NON-NLS-1$ Line 49: } Line 50: }; Line 51: nameColumn.makeSortable(); Line 52: getTable().addColumn(nameColumn, constants.storageQosName(), "200px"); //$NON-NLS-1$ storage? Line 53: Line 54: TextColumnWithTooltip<HostNetworkQos> descColumn = new TextColumnWithTooltip<HostNetworkQos>() { Line 55: @Override Line 56: public String getValue(HostNetworkQos object) { Line 57: return object.getDescription() == null ? "" : object.getDescription(); //$NON-NLS-1$ Line 58: } Line 59: }; Line 60: descColumn.makeSortable(); Line 61: getTable().addColumn(descColumn, constants.storageQosDescription(), "150px"); //$NON-NLS-1$ storage? Line 62: Line 63: TextColumnWithTooltip<HostNetworkQos> outAverageLinkshareColumn = new TextColumnWithTooltip<HostNetworkQos>() { Line 64: @Override Line 65: public String getValue(HostNetworkQos object) { Line 93: newStorageQos storage? Line 96: return getDetailModel().getNewCommand(); Line 97: } Line 98: }); Line 99: Line 100: getTable().addActionButton(new WebAdminButtonDefinition<HostNetworkQos>(constants.editStorageQos()) { storage? Line 101: @Override Line 102: protected UICommand resolveCommand() { Line 103: return getDetailModel().getEditCommand(); Line 104: } Line 103: return getDetailModel().getEditCommand(); Line 104: } Line 105: }); Line 106: Line 107: getTable().addActionButton(new WebAdminButtonDefinition<HostNetworkQos>(constants.removeStorageQos()) { storage? Line 108: @Override Line 109: protected UICommand resolveCommand() { Line 110: return getDetailModel().getRemoveCommand(); Line 111: } -- To view, visit http://gerrit.ovirt.org/34129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6effa72b6a3bc336921a69803600f5a5c7367aff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
