Lior Vernia has posted comments on this change. Change subject: webadmin: Add HostNetworkQos widget ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/34127/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java: Line 3427: Line 3428: @DefaultStringValue("Weighted Share") Line 3429: String hostNetworkQosPopupOutAverageLinkshare(); Line 3430: Line 3431: @DefaultStringValue("Rate Limit [Mbps]") > Don't you think it would be nicer if the Mbps would be after the text box. You know our layout issues... We tried to do that with the Network QoS dialog and it turned out awful :) Line 3432: String hostNetworkQosPopupOutAverageUpperlimit(); Line 3433: Line 3434: @DefaultStringValue("Committed Rate [Mbps]") Line 3435: String hostNetworkQosPopupOutAverageRealtime(); http://gerrit.ovirt.org/#/c/34127/4/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/qos/HostNetworkQosWidget.ui.xml: Line 16: } Line 17: </ui:style> Line 18: Line 19: <g:FlowPanel ui:field="mainPanel" > Line 20: <g:Label text="{constants.hostNetworkQosOutLabel}" addStyleNames="{style.labelStyle}" /> > I don't like setting constants in ui.xml files. Eclipse doesn't find the co I'm generally with you on this, but since this saves me a member in the Java class... Line 21: <e:IntegerEntityModelTextBoxEditor ui:field="outAverageLinkshare" /> Line 22: <e:IntegerEntityModelTextBoxEditor ui:field="outAverageUpperlimit" /> Line 23: <e:IntegerEntityModelTextBoxEditor ui:field="outAverageRealtime" /> Line 24: </g:FlowPanel> -- To view, visit http://gerrit.ovirt.org/34127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a97c260ba18d21d911a0338149fefc2c6222c52 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
