Roy Golan has uploaded a new change for review. Change subject: core: VM should be PINNED+TO_HOST when using host cpu flags ......................................................................
core: VM should be PINNED+TO_HOST when using host cpu flags according to the bug a VM using pass-through host cpu (host cpu flags) might bump into issues when migrating to cpu lower than the SRC hardware and this is, apparently not supported Change-Id: I781891e91680bbe8095097a2a1e4c426e318c720 Bug-Url: https://bugzilla.redhat.com/1052168 Signed-off-by: Roy Golan <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/34883/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java index 710820c..ebbc733 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java @@ -582,7 +582,7 @@ } if (vmFromParams.isUseHostCpuFlags() - && vmFromParams.getMigrationSupport() == MigrationSupport.MIGRATABLE) { + && vmFromParams.getMigrationSupport() != MigrationSupport.PINNED_TO_HOST) { return failCanDoAction(VdcBllMessages.VM_HOSTCPU_MUST_BE_PINNED_TO_HOST); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java index 3792dbb..2115821 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java @@ -593,7 +593,7 @@ } if (vmFromParams.isUseHostCpuFlags() - && vmFromParams.getMigrationSupport() == MigrationSupport.MIGRATABLE) { + && vmFromParams.getMigrationSupport() != MigrationSupport.PINNED_TO_HOST) { return failCanDoAction(VdcBllMessages.VM_HOSTCPU_MUST_BE_PINNED_TO_HOST); } -- To view, visit http://gerrit.ovirt.org/34883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I781891e91680bbe8095097a2a1e4c426e318c720 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
