Allon Mureinik has posted comments on this change. Change subject: WIP - don't submit core: disk related DB permission changes (#846300) ......................................................................
Patch Set 1: I would prefer that you didn't submit this (4 inline comments) .................................................... File backend/manager/dbscripts/create_functions.sql Line 249: WHEN v_entity_type = 11 THEN -- Storage Domain Indent under the other "WHEN" statements. Line 251: v_storage_id := ( SELECT id from storage_domain_static WHERE id = v_entity_id ); I don't get this query. please explain. .................................................... File backend/manager/dbscripts/upgrade/03_01_1350_add_disk_permissions_to_vm_creator_role.sql Line 21: ); see comment in the commit message .................................................... Commit Message Line 17: 2. Makes the VM Creator role also able to create/edit/configure disks. I get (even if I don't really agree) why VMCreator should be able to create disks, but why give ti permissions to edit them? -- To view, visit http://gerrit.ovirt.org/7002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89a0dd5af9a99f1acd59c2de66062588179ae656 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
