Moran Goldboim has posted comments on this change. Change subject: packaging: Change error message when using occupied port (#BZ813688) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) lease choose one method to take care of - INFO_VAL_CHOOSE_PORT .................................................... File packaging/fedora/setup/engine_validators.py Line 89: print output_messages.INFO_VAL_FAILED_ADD_PORT_TO_HTTP_POLICY % port please choose one method to take care of - INFO_VAL_CHOOSE_PORT , if by adding it to relevant messages (should be in warn class from my perspective) or use it the flow. -- To view, visit http://gerrit.ovirt.org/7000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf2128a9bdd96eab550e96483b6447969755cef8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
