Ravi Nori has uploaded a new change for review. Change subject: engine : Set endAction try again to false on failure ......................................................................
engine : Set endAction try again to false on failure On failure of commands with handlers, if no handler has been executed the endWithFailure is not invoked on the handlers. This can leave setEndActionTryAgain to true causing AsyncTaskManager to continuously wait for commands completion. In such cases the CommandBase should set the setEndActionTryAgain to false so the command can converge. Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Bug-Url: https://bugzilla.redhat.com/1159325 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/34942/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 4e7296e..718cec4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -652,6 +652,9 @@ if (hasStepsToRevert()) { getCurrentTaskHandler().endWithFailure(); revertPreviousHandlers(); + } else { + // since no handlers have been run we don't have to retry endAction + getReturnValue().setEndActionTryAgain(false); } startPollingAsyncTasks(); } else { -- To view, visit http://gerrit.ovirt.org/34942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idf6f8755a22f2654b9af6678f1353f9b6ae08942 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
