Daniel Erez has uploaded a new change for review. Change subject: Revert "core: Improve performance of getdisksvmguid" ......................................................................
Revert "core: Improve performance of getdisksvmguid" This reverts commit d9e489471aaf0113fac7dff63845dee6f7f4523e. UNION removes duplicate records, UNION ALL does not. Hence, 'all_disks_including_snapshots' view includes duplicate records for copied template disks. Performance improvement should probably be achieved in another way. In the mean time, reverting this change. Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Bug-Url: https://bugzilla.redhat.com/1161612 Signed-off-by: Daniel Erez <[email protected]> --- M packaging/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/34958/1 diff --git a/packaging/dbscripts/create_views.sql b/packaging/dbscripts/create_views.sql index 7e47cd0..92bc473 100644 --- a/packaging/dbscripts/create_views.sql +++ b/packaging/dbscripts/create_views.sql @@ -221,7 +221,7 @@ null AS device_size FROM images_storage_domain_view INNER JOIN storage_for_image_view ON images_storage_domain_view.image_guid = storage_for_image_view.image_id - UNION ALL + UNION SELECT 1 AS disk_storage_type, null AS storage_id, -- Storage domain fields null AS storage_path, -- To view, visit http://gerrit.ovirt.org/34958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f6a0859a6000124e7968e5725ed7e5232b1a5cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
