Gilad Chaplik has posted comments on this change. Change subject: core: Push ioTune QoS info when hotplugging disk ......................................................................
Patch Set 3: Code-Review+1 (2 comments) minor comments, pls fix on rebase. http://gerrit.ovirt.org/#/c/33907/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 361: Line 362: ArchStrategyFactory.getStrategy(vm.getClusterArch()).run(new CreateAdditionalControllers(devices)); Line 363: } Line 364: Line 365: static Map<String, Long> buildIoTune(DiskImage diskImage, it's custom to declare access modifier. Line 366: Map<Guid, Guid> diskProfileStorageQosMap, Line 367: Map<Guid, Map<String, Long>> storageQosIoTuneMap) { Line 368: Guid diskProfileId = diskImage.getDiskProfileId(); Line 369: if (diskProfileId == null) { Line 387: } Line 388: return null; Line 389: } Line 390: Line 391: static private Map<String, Long> buildIoTuneMap(StorageQos storageQos) { s/private static/static private/ Line 392: // build map Line 393: Map<String, Long> ioTuneMap = new HashMap<>(); Line 394: if (storageQos.getMaxThroughput() != null) { Line 395: // Convert MiB/s to B/s vdsm is expecting -- To view, visit http://gerrit.ovirt.org/33907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
