Shireesh Anjal has posted comments on this change. Change subject: bootstrap: allow retrieve ssh key fingerprint of server ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Looks good to me, one minor inline comment. .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java Line 124: throw e; In general, I think it is better to throw a 'RuntimeException', thus not forcing the calling code to necessarily put try-catch blocks (or throws clause). -- To view, visit http://gerrit.ovirt.org/6997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08554a5daac4f43b514a7211abdfbb61d2cc5ace Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
